-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add locality failover example to the ambient multicluster docs #16949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of wording suggestions but other than that LGTM (assuming tests pass)
|
/test doc.test.multicluster |
|
did a quick read over, lgtm |
|
This should be good to rebase now that master is on istio 1.28 |
This example requires changes introduced in #58065 and #57963. These PRs enable waypoints to route requests to remote network via ambient E/W gateway (using double HBONE). It's all required to address #57537. With those changes in we can extend the initial multicluster setup example to show how to configure locality failover and along the way demonstrate how to deploy waypoints in multicluster ambient environments. Signed-off-by: Mikhail Krinkin <[email protected]>
Signed-off-by: Mikhail Krinkin <[email protected]>
Signed-off-by: Mikhail Krinkin <[email protected]>
Signed-off-by: Mikhail Krinkin <[email protected]>
Signed-off-by: Mikhail Krinkin <[email protected]>
1cf9093 to
88de327
Compare
Co-authored-by: Keith Mattix II <[email protected]>
Co-authored-by: Keith Mattix II <[email protected]>
|
/test lint |
Signed-off-by: Mikhail Krinkin <[email protected]>
…r docs into Chinese
…#16949) * Add locality failover example to the ambient multicluster docs This example requires changes introduced in #58065 and #57963. These PRs enable waypoints to route requests to remote network via ambient E/W gateway (using double HBONE). It's all required to address #57537. With those changes in we can extend the initial multicluster setup example to show how to configure locality failover and along the way demonstrate how to deploy waypoints in multicluster ambient environments. Signed-off-by: Mikhail Krinkin <[email protected]> * Fix output snippet lang from bash to plain to address lint warning Signed-off-by: Mikhail Krinkin <[email protected]> * Fix lints Signed-off-by: Mikhail Krinkin <[email protected]> * regenerate snips Signed-off-by: Mikhail Krinkin <[email protected]> * Fix typo Signed-off-by: Mikhail Krinkin <[email protected]> * Update content/en/docs/ambient/install/multicluster/_index.md Co-authored-by: Keith Mattix II <[email protected]> * Update content/en/docs/ambient/install/multicluster/_index.md Co-authored-by: Keith Mattix II <[email protected]> * fix lint warning Signed-off-by: Mikhail Krinkin <[email protected]> --------- Signed-off-by: Mikhail Krinkin <[email protected]> Co-authored-by: Keith Mattix II <[email protected]>
Description
This example requires changes introduced in #58065 and #57963. These PRs enable waypoints to route requests to remote network via ambient E/W gateway (using double HBONE). It's all required to address #57537.
With those changes in we can extend the initial multicluster setup example to show how to configure locality failover and along the way demonstrate how to deploy waypoints in multicluster ambient environments.
Reviewers
+cc @therealmitchconnors @keithmattix @Stevenjin8 @jaellio @mikemorris